Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA-3909 Append scenario for AI3 #4

Merged
merged 30 commits into from
Nov 7, 2023
Merged

QA-3909 Append scenario for AI3 #4

merged 30 commits into from
Nov 7, 2023

Conversation

ahitrin
Copy link
Contributor

@ahitrin ahitrin commented Nov 6, 2023 •
edited
Loading

  1. Add new append test.
  2. Remove artifical limit on generated operations in ignite3/generator.
  3. Rename bindings causing name conflicts (warnings during compilation): test, key.

ahitrin added 25 commits October 30, 2023 19:00
@ahitrin
Append test, not working yet
89271d0
@ahitrin
Avoid infinite print
3eeba16
@ahitrin
Do not shadow names like "test" and "key"
01b9d97 
Fix compilation warnings.
@ahitrin
Rebalance open! and setup! methods
9be060c 
It's not recommended to alter DB state in open! method. Instead, setup!
method should be used for that.
@ahitrin
Stupid value insert (ignoring jepsen data for now)
ed2da47
@ahitrin
wip
1aee052
@ahitrin
wip
71f6a7d
@ahitrin
extract
dadb739
@ahitrin
fixes
918849f
@ahitrin
convert result into list
0371300
@ahitrin
insert or update
13a5d7b
@ahitrin
destructure
b520274
@ahitrin
simplify
0053c29
@ahitrin
fix
33aa17a
@ahitrin
Add pseudo-nemesis for append test
981fd18
@ahitrin
Comment out debug logging
d02caf7
@ahitrin
cleanup
f75442f
@ahitrin
cleanup imports
bfc7ff5
@ahitrin
extract run-sql function
aff40a8
@ahitrin
Try to setup consistency models
fac6e10
@ahitrin
Remove unused pds settings
aa0694c
@ahitrin
convert long expression into several steps
2c9d4b1
@ahitrin
Fix: do not use test name "basic-test"
c0d499a
@ahitrin
Explicitly open transaction for read
2224265
@ahitrin
simplify
1703392
@ahitrin ahitrin requested review from Berkof and iartiukhov November 6, 2023 09:53
iartiukhov
iartiukhov approved these changes Nov 6, 2023
View reviewed changes
Copy link

@iartiukhov iartiukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the idea and realization are looking good to me!

@ahitrin ahitrin marked this pull request as ready for review November 7, 2023 04:52
@ahitrin ahitrin merged commit 0b69ef9 into main Nov 7, 2023
@ahitrin ahitrin deleted the QA-3909 branch November 7, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iartiukhov iartiukhov iartiukhov approved these changes

@Berkof Berkof Awaiting requested review from Berkof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahitrin @iartiukhov