-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize #33
Dockerize #33
Conversation
@JamesKyburz Merged 🎉 |
@JamesKyburz Thanks for instruction I setup build on dockerhub: Can you please help me to figure it out? |
@IvanGoncharov, I suppose, that your |
@IvanGoncharov, also don't forget to update Docker image name in the README. Now it's wrong — |
@romandragan @IvanGoncharov Sorry but we haven't completed the automatic build on dockerhub yet. We should be able to fix that in the next few days. |
@IvanGoncharov Sorry I didn't get time to help :( I had a look on dockerhub and looks like you got it working? |
@JamesKyburz I suspect so. I would say DockeHub UI is pretty confusing: If you have time, can you please test that |
@IvanGoncharov I had a look and yes the v1.6.2 tagged image looks good :) ~ ᐅ docker run -ti --entrypoint=/bin/sh apisguru/graphql-faker:v1.6.2
/ # cat /usr/local/lib/node_modules/graphql-faker/package.json | grep version
"version": "1.6.2"
~ ᐅ docker run -p 9002:9002 apisguru/graphql-faker:v1.6.2 |
This
PR
adds docker as an option to run.The build will need to be setup using dockerhub (automated repository)
I would use the build settings with a github trigger (this presumes the use of git tags which
npm version
can create for us)tag /^v[0-9.]+/
branch master latest
This would build latest on each published version along with a tagged version.