Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #33

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Dockerize #33

merged 2 commits into from
Nov 10, 2017

Conversation

JamesKyburz
Copy link
Contributor

This PR adds docker as an option to run.

The build will need to be setup using dockerhub (automated repository)

I would use the build settings with a github trigger (this presumes the use of git tags which npm version can create for us)

tag /^v[0-9.]+/
branch master latest

This would build latest on each published version along with a tagged version.

@IvanGoncharov IvanGoncharov merged commit dc4d49e into graphql-kit:master Nov 10, 2017
@IvanGoncharov
Copy link
Member

@JamesKyburz Merged 🎉
Sorry for the delay, it was a pretty busy month for us.

@IvanGoncharov
Copy link
Member

@JamesKyburz Thanks for instruction I setup build on dockerhub:
https://hub.docker.com/r/apisguru/graphql-faker/
And published new 1.5.1 version with matching tag:
https://github.com/APIs-guru/graphql-faker/tags
But I don't see it here:
https://hub.docker.com/r/apisguru/graphql-faker/tags/

Can you please help me to figure it out?

@romandrahan
Copy link

@IvanGoncharov, I suppose, that your 1.5.1 tag just became latest on Docker Hub, cause it's only one, that exists in your repository. Once you'll publish new tag, it will appear on Docker Hub too.

@romandrahan
Copy link

romandrahan commented Nov 18, 2017

@IvanGoncharov, also don't forget to update Docker image name in the README. Now it's wrong — graphql-faker, but must be full apisguru/graphql-faker.

@JamesKyburz
Copy link
Contributor Author

JamesKyburz commented Nov 18, 2017

@romandragan @IvanGoncharov Sorry but we haven't completed the automatic build on dockerhub yet. We should be able to fix that in the next few days.

@JamesKyburz
Copy link
Contributor Author

@IvanGoncharov Sorry I didn't get time to help :( I had a look on dockerhub and looks like you got it working?

@IvanGoncharov
Copy link
Member

IvanGoncharov commented Nov 25, 2017

@JamesKyburz I suspect so. I would say DockeHub UI is pretty confusing:
image

If you have time, can you please test that 1.6.2 is correct build?

@JamesKyburz
Copy link
Contributor Author

@IvanGoncharov I had a look and yes the v1.6.2 tagged image looks good :)

~ ᐅ docker run -ti --entrypoint=/bin/sh apisguru/graphql-faker:v1.6.2
/ #  cat /usr/local/lib/node_modules/graphql-faker/package.json  | grep version
  "version": "1.6.2"
~ ᐅ docker run -p 9002:9002  apisguru/graphql-faker:v1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants