Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom map types in resolvers #440

Merged
merged 3 commits into from
Mar 10, 2019
Merged

Support custom map types in resolvers #440

merged 3 commits into from
Mar 10, 2019

Conversation

atombender
Copy link
Contributor

Support custom map types (e.g. type Thing map[string]interface{}) by falling back to reflection. Fixes #439.

@atombender
Support custom map types in resolvers (e.g.
0beacfd 
`type Thing map[string]interface{}`) by falling back to reflection.
Fixes graphql-go#439.
@atombender
Adds regression test for graphql-go#439.
db6bc15
@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 92.17% when pulling 66aaed7 on atombender:issue-439 into bf68c1b on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — Thanks a lot @atombender, neat improvement 🚢 💯

@chris-ramon chris-ramon merged commit c13c47a into graphql-go:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atombender @coveralls @chris-ramon