Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum nil pointer safety #370

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Conversation

sfriedel
Copy link
Contributor

Similar to #369 this fixes another issue where Enum values would panic when trying to be resolved on a nil pointer.

I've also added tests for the Union, Interface and List types for their nil pointer handling but they did not need any fixes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.919% when pulling 6b054a4 on civist:nil-pointer-safety into a13937c on graphql-go:master.

@chris-ramon
Copy link
Member

Awesome!, thanks a lot @sfriedel 👍

@chris-ramon chris-ramon merged commit 990c305 into graphql-go:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants