Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor treats arrays as iterable #327

Merged
merged 3 commits into from
Jul 2, 2018
Merged

Executor treats arrays as iterable #327

merged 3 commits into from
Jul 2, 2018

Conversation

alexflint
Copy link
Contributor

@alexflint alexflint commented May 25, 2018 •
edited
Loading

This pr changes the executor to treat Go arrays as iterable. This means that if a user defines a schema including a graphql.List, and the value for that list is an array, then the array will be serialized as a json list.

Closes #323

@alexflint alexflint changed the title treat arrays as iterable Executor treats arrays as iterable May 25, 2018
@coveralls
Copy link

coveralls commented May 25, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 81.092% when pulling a0d7034 on alexflint:match-arrays-as-lists into 51e8a07 on graphql-go:master.

@glaslos
Copy link

glaslos commented Jun 16, 2018

LGTM

@alexflint
Copy link
Contributor Author

Ping @glaslos

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @alexflint

@chris-ramon chris-ramon merged commit 2f78272 into graphql-go:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexflint @coveralls @glaslos @chris-ramon