Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql-ws type import #3811

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: graphql-ws type import #3811

merged 1 commit into from
Nov 22, 2024

Conversation

acao
Copy link
Member

@acao acao commented Nov 22, 2024

fixes #2405

switching to a type import will prevent bundling issues with legacy bundlers, as the older babel/ts transforms will know to strip type only imports before build time

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: b94ff26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphiql/toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 22, 2024

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphiql@3.7.3-canary-c0342c2d.0
@graphiql/plugin-code-exporter@3.1.4-canary-c0342c2d.0
@graphiql/plugin-explorer@3.2.4-canary-c0342c2d.0
@graphiql/react@0.27.1-canary-c0342c2d.0
@graphiql/toolkit@0.11.1-canary-c0342c2d.0

@acao acao force-pushed the fix-2405-graphql-ws-import branch from d6dbcc1 to b94ff26 Compare November 22, 2024 05:12
@acao acao merged commit 5f2c3a4 into main Nov 22, 2024
14 checks passed
@acao acao deleted the fix-2405-graphql-ws-import branch November 22, 2024 05:17
@acao acao mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve graphql-ws from @graphiql/toolkit/esm/create-fetcher
1 participant