Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matchstick examples #86

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Update matchstick examples #86

merged 1 commit into from
Mar 14, 2022

Conversation

pete-eiger
Copy link
Contributor

Updating Matchstick examples with the latest version of the framework.

@pete-eiger pete-eiger requested a review from a team as a code owner March 10, 2022 21:56
@PtomelySoter
Copy link

This is looking great! Do we have examples for setting up tests for callHandlers? It would also be good to add in that event parameters need to match the order of the event itself.

@PtomelySoter
Copy link

Happy to come up with some copy for this. @axiomatic-aardvark

Copy link
Member

@schmidsi schmidsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great improvements.

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@azf20
Copy link
Contributor

azf20 commented Mar 14, 2022

Thanks @axiomatic-aardvark! @PtomelySoter definitely good idea, but I think best to address in a separate PR

@azf20 azf20 merged commit 860a8e4 into graphprotocol:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants