Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Goerli GRT contract addresses #389

Merged
merged 1 commit into from
May 27, 2023
Merged

Added Goerli GRT contract addresses #389

merged 1 commit into from
May 27, 2023

Conversation

marcusrein
Copy link
Member

Docs were missing the Goerli GRT contract addresses for Ethereum and Arbitrum.

Docs were missing the Goerli GRT contract addresses for Ethereum and Arbitrum.
@github-actions
Copy link

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/en/network-transition-faq 13.67 KB 651.09 KB 186.03% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@MichaelMacaulay MichaelMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work!

@marcusrein marcusrein marked this pull request as ready for review May 27, 2023 00:17
@marcusrein marcusrein requested a review from a team as a code owner May 27, 2023 00:17
@marcusrein marcusrein merged commit 1761395 into main May 27, 2023
@marcusrein marcusrein deleted the marcusrein-patch-1 branch May 27, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants