Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Scala, sbt, and sbt-plugins version #342

Closed
wants to merge 6 commits into from
Closed

Bump Scala, sbt, and sbt-plugins version #342

wants to merge 6 commits into from

Conversation

jiminhsieh
Copy link

We have to update Spark patch version since there are no 2.3.2 and 2.4.0 at mirror site. In the meantime, I update sbt and sbt-plugins' patch version.

@codecov-io
Copy link

codecov-io commented Jul 9, 2019 •
edited
Loading

Codecov Report

Merging #342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          18       18           
  Lines         871      871           
  Branches       73       49   -24     
=======================================
  Hits          795      795           
  Misses         76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a30adaf...a4b3f00. Read the comment docs.

felixcheung
felixcheung reviewed Jul 10, 2019
View reviewed changes
build.sbt
@@ -63,7 +63,7 @@ scalacOptions in (Test, doc) ++= Seq("-groups", "-implicits")
fork in Test := true

// This and the next line fix a problem with forked run: https://github.com/scalatest/scalatest/issues/770
javaOptions in Test ++= Seq("-Xmx2048m", "-XX:ReservedCodeCacheSize=384m", "-XX:MaxPermSize=384m")
javaOptions in Test ++= Seq("-Xmx2048m", "-XX:ReservedCodeCacheSize=384m", "-XX:MaxMetaspaceSize=384m")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxPermSize was deprecated at JDK 8. It was replaced by MaxMetaspaceSize

@simonyun
Copy link

simonyun commented Aug 15, 2019 •
edited
Loading

Hello, any ETA on when this might be merged and released? I'd like to upgrade our Spark-dependent code to Scala 2.12.x, and graphframes is the last 2.11.x holdout. Thank you!

@jiminhsieh jiminhsieh changed the title Bump Spark and sbt version Bump Scala, sbt, and sbt-plugins version Oct 17, 2019
@jiminhsieh
Copy link
Author

update Spark patch version since there are no 2.3.2 and 2.4.0 at mirror site

Spark patch version was upgraded at #343

@mengxr mengxr mentioned this pull request Mar 20, 2020
Merged
mengxr added a commit that referenced this pull request Mar 20, 2020
@mengxr
build against 3.0.0-preview2 and update build/version (#361)
624170b 
* build against Spark 3.0.0-preview2
* update travis to 18.04
* remove python 2 build
* bump version to 0.8.0-SNAPSHOT.
* update scala and sbt plugin versions
* update doc build and remove pygments (Rouge is the default)

Closes #348 #342
@mengxr
Copy link
Contributor

mengxr commented Apr 21, 2020

Closing this as we upgraded to Spark 3.0 and Scala 2.12.

@mengxr mengxr closed this Apr 21, 2020
@mengxr
Copy link
Contributor

mengxr commented Apr 21, 2020

Closing this as we upgraded to Spark 3.0 and Scala 2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixcheung felixcheung felixcheung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiminhsieh @codecov-io @simonyun @mengxr @felixcheung