-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5449: Pedigree view crashes if you happen to choose a child as ancestor #102
Conversation
@@ -86,6 +86,7 @@ def __init__(self, | |||
self.MAX_SIB_AGE_DIFF = max_sib_age_diff | |||
self.MAX_AGE_PROB_ALIVE = max_age_prob_alive | |||
self.AVG_GENERATION_GAP = avg_generation_gap | |||
self.plist = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you made this a set() rather than a list(), then when you check for a containing person, it can happen in constant time, rather than a sequential search.
Is this ready to go? |
Worked for me, Suggestions:
The following warning is output: Minor editorial issue:
|
What is the best way to add a loop example to example.gramps ? |
I have not tried to run this but just from a quick glance I see that |
I am just guessing, since I haven't tried to run it, but when you ask |
I was thinking to add a new testloop.gramps in example/gramps I suppressed ", TOOL_MODE_CLI" in tools.gpr.py |
What is the best way to remove the three last patchs ? OK finaly done with : |
I propose to add two example files : The help file for wiki 5.0 is done. perhaps we need some corrections. |
If you agree, it's OK for me. |
As far as names, I'd suggest something more generic, Also, as long as I'm offering opinions, I'd say that instead of |
…ted glade problem.
Sorry. I saw you made modifications. Do I need to restaure some data ? is it correct for you ?
I think this is related to the glade file. Done.
Done. |
@SNoiraud Sorry. I saw you made modifications. Do I need to restaure some data ? is it correct for you ? No I've already fixed it. Tested with the each of the example files and it works 👍 Thanks for all your efforts |
I added the possibility to have loops in the database.
I added a new tool to find these loops.