[Traceql Metrics] PR 3 - Trace ID sharding #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
annanay25,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
This was referenced Dec 21, 2023
3 tasks
… it from seeming successful
mdisibio
force-pushed
the
traceql-metrics-3-sharding
branch
from
f79e36b
to
08cb7a8
Compare
zalegrala
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR implements the trace-ID sharding used by metrics in the block Fetch() method. For context: the query-frontend divides a metrics query into jobs along 2 dimensions: horizontally across time (i.e. a job every 5 minutes) and vertically across trace IDs (i.e. 10 shards). This PR is the vertical scaling. For example: shard "10 of 16" processes only traces A00.... through AFF.... This is done with a predicate against the TraceID column.
There are some other details to be aware:
Notes
This is one entry in a set of chained PRs. The full body of work has been split into separate buckets to make reviews and updates more manageable.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]