Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main two goals of this PR are:
To achieve the first goal, we have to override go-retryablehttp's
CheckRetry
function, adding cases when the request should not be retried. This depends not only on the response status code from Druid, but also on the response body, as indicated from the different error codes detailed in Druid's documentation.To handle the second goal, both
CheckRetry
andErrorHandler
need to be overriden.CheckRetry
needs to return the error received from Druid, andErrorHandler
needs to pass this error forward, as well as perform some clean-up.