Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add thetaSketch aggregator #41

Merged
merged 4 commits into from
Apr 2, 2021
Merged

add thetaSketch aggregator #41

merged 4 commits into from
Apr 2, 2021

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Apr 1, 2021

No description provided.

@vigith
Copy link
Collaborator

vigith commented Apr 1, 2021

please add testing

@vigith vigith requested review from jbguerraz and removed request for jbguerraz April 1, 2021 18:33
@jy4096 jy4096 marked this pull request as ready for review April 1, 2021 20:32
@vigith vigith requested review from jbguerraz and vigith April 1, 2021 20:49
vigith
vigith approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbguerraz
jbguerraz requested changes Apr 2, 2021
View reviewed changes
builder/aggregation/thetasketch_test.go Outdated Show resolved Hide resolved
@jy4096 jy4096 requested a review from jbguerraz April 2, 2021 16:28
jbguerraz
jbguerraz approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@jbguerraz jbguerraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chromevoid 👍

@jbguerraz jbguerraz merged commit 7385bcd into grafadruid:master Apr 2, 2021
@jy4096 jy4096 deleted the thetaSketch branch September 21, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbguerraz jbguerraz jbguerraz approved these changes

@vigith vigith vigith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jy4096 @vigith @jbguerraz