Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffers,map_ArrayBuffer:* fake transfer of mapped array buffers #1027

Merged
merged 3 commits into from
Mar 3, 2022
Merged

buffers,map_ArrayBuffer:* fake transfer of mapped array buffers #1027

merged 3 commits into from
Mar 3, 2022

Conversation

austinEng
Copy link
Collaborator

@austinEng austinEng commented Mar 1, 2022 •
edited by kainino0x
Loading

Passes with updated Chromium implementation in https://chromium-review.googlesource.com/c/chromium/src/+/3496685

Issue: #1033

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Previews, as seen when this build job started (0f0dc6c):
Run tests | View tsdoc

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Previews, as seen when this build job started (1afab9e):
Run tests | View tsdoc

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Previews, as seen when this build job started (4d0cd44):
Run tests | View tsdoc

@austinEng austinEng marked this pull request as ready for review March 1, 2022 22:31
@austinEng austinEng requested a review from kainino0x March 1, 2022 22:31
@kainino0x
Copy link
Collaborator

Issue is #1033 (I just converted the draft to an issue)

@austinEng austinEng enabled auto-merge (squash) March 3, 2022 00:54
@austinEng austinEng merged commit efbc6aa into gpuweb:main Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Previews, as seen when this build job started (5a05b54):
Run tests | View tsdoc

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Previews, as seen when this build job started (6b50a4c):
Run tests | View tsdoc

@austinEng austinEng deleted the mapping-transfer branch March 3, 2022 01:01
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 3, 2022
@austinEng
Implement copy-on-transfer semantics for GPUMappedArrayBuffer
2d525d2 
See gpuweb/gpuweb#2072 (comment)
Passes updated tests in gpuweb/cts#1027

Bug: 1243842
Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976902}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 3, 2022
@austinEng
Revert "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
7146831 
This reverts commit 2d525d2.

Reason for revert: WebGPUExpectations update needs to re-run generator.

Original change's description:
> Implement copy-on-transfer semantics for GPUMappedArrayBuffer
>
> See gpuweb/gpuweb#2072 (comment)
> Passes updated tests in gpuweb/cts#1027
>
> Bug: 1243842
> Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#976902}

Bug: 1243842
Change-Id: I20459fce5efe4987040f5e3dd9cc1b4338acd27f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501104
Auto-Submit: Austin Eng <enga@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976943}
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 3, 2022
@austinEng
Reland "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
68365a9 
This reverts commit 7146831.

Reason for revert: Fixed instead by https://chromium-review.googlesource.com/c/chromium/src/+/3499755

Original change's description:
> Revert "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
>
> This reverts commit 2d525d2.
>
> Reason for revert: WebGPUExpectations update needs to re-run generator.
>
> Original change's description:
> > Implement copy-on-transfer semantics for GPUMappedArrayBuffer
> >
> > See gpuweb/gpuweb#2072 (comment)
> > Passes updated tests in gpuweb/cts#1027
> >
> > Bug: 1243842
> > Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> > Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> > Commit-Queue: Austin Eng <enga@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#976902}
>
> Bug: 1243842
> Change-Id: I20459fce5efe4987040f5e3dd9cc1b4338acd27f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501104
> Auto-Submit: Austin Eng <enga@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
> Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#976943}

Bug: 1243842
Change-Id: Ie124d05f59c330f8f5a4b1ba223d9608bc786cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500883
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976959}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@austinEng @copybara-github
Implement copy-on-transfer semantics for GPUMappedArrayBuffer
2167b6b 
See gpuweb/gpuweb#2072 (comment)
Passes updated tests in gpuweb/cts#1027

Bug: 1243842
Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976902}
NOKEYCHECK=True
GitOrigin-RevId: 2d525d281fa5c1a234baf36310e303cb9c54b697
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@austinEng @copybara-github
Revert "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
fe57f72 
This reverts commit 2d525d281fa5c1a234baf36310e303cb9c54b697.

Reason for revert: WebGPUExpectations update needs to re-run generator.

Original change's description:
> Implement copy-on-transfer semantics for GPUMappedArrayBuffer
>
> See gpuweb/gpuweb#2072 (comment)
> Passes updated tests in gpuweb/cts#1027
>
> Bug: 1243842
> Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#976902}

Bug: 1243842
Change-Id: I20459fce5efe4987040f5e3dd9cc1b4338acd27f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501104
Auto-Submit: Austin Eng <enga@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976943}
NOKEYCHECK=True
GitOrigin-RevId: 714683105559d161e173df8420a19c9cb2cecb1f
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@austinEng @copybara-github
Reland "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
ad4f784 
This reverts commit 714683105559d161e173df8420a19c9cb2cecb1f.

Reason for revert: Fixed instead by https://chromium-review.googlesource.com/c/chromium/src/+/3499755

Original change's description:
> Revert "Implement copy-on-transfer semantics for GPUMappedArrayBuffer"
>
> This reverts commit 2d525d281fa5c1a234baf36310e303cb9c54b697.
>
> Reason for revert: WebGPUExpectations update needs to re-run generator.
>
> Original change's description:
> > Implement copy-on-transfer semantics for GPUMappedArrayBuffer
> >
> > See gpuweb/gpuweb#2072 (comment)
> > Passes updated tests in gpuweb/cts#1027
> >
> > Bug: 1243842
> > Change-Id: I3024b0185b4bdff3daf2ed32ab0f7286a4dbd1ff
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496685
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> > Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> > Commit-Queue: Austin Eng <enga@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#976902}
>
> Bug: 1243842
> Change-Id: I20459fce5efe4987040f5e3dd9cc1b4338acd27f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501104
> Auto-Submit: Austin Eng <enga@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
> Owners-Override: Nidhi Jaju <nidhijaju@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#976943}

Bug: 1243842
Change-Id: Ie124d05f59c330f8f5a4b1ba223d9608bc786cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500883
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976959}
NOKEYCHECK=True
GitOrigin-RevId: 68365a9dc0a62413d5f2c2a96f926ef540ee6ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinEng @kainino0x