deps: upgrade x/tools and gopls to 77f530d86f9a #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leitzler
commented
Jul 26, 2020
•
leitzler
commented
leitzler
force-pushed
the
deps_tools_77f530d86f9a
branch
from
25ee4b6 to
339e890
Compare
myitcv
reviewed
Jul 27, 2020
leitzler
force-pushed
the
deps_tools_77f530d86f9a
branch
2 times, most recently
from
115a084 to
b3e1663
Compare
* internal/lsp: handle deletion of file content 77f530d8 * internal/lsp: move fillstruct suggested fixes out of analysis 4025ed84 * internal/lsp: support extract function 6d307edf * internal/lsp: split only on the first = for Go environment variables 9cbb971a * internal/lsp: support go1.12 cf97b7f4 * internal/lsp: don't re-run `go env` for every call to WriteEnv e6549b8d The update also updates the fillstruct logic according to recent changes in gopls where it now return Commands instead of direct edits. As gopls went from edits to commands, it will not be possible to fill more than one struct per fillstruct call. This also adds support for incoming LSP ApplyEdit calls, to be able to use LSP ExecuteCommand.
leitzler
force-pushed
the
deps_tools_77f530d86f9a
branch
from
b3e1663 to
7d570d4
Compare
leitzler
changed the title
myitcv
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.