Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News view fix (I think this app deserves a lot of love) #2

Merged
merged 3 commits into from
May 23, 2016

Conversation

Turupawn
Copy link
Contributor

@Turupawn Turupawn commented May 23, 2016

Changes summary

  • "No games found on your developer account." message shown instead of an eternal loading screen.
  • Fixed the News view so it will load the news inside the app instead launching a web browser
  • Removed the .idea/ directory and the .iml files because they are generated when the project is built
  • Added the .idea/ directory and .iml files to the .gitignore
  • Fixed the progress bar, however I couldn't hide it when the website is fully loaded because it continuously load a lot of stuff

Screenshots

Old version (with errors)


Eternal loading screen if no games found


When the user opens the news view, it launches the browser


When you return to the app, a blank news page is shown

New version (fixed)


Message shown if the user has no games


Now the tumblr news are loaded inside the app

@gotosleep gotosleep merged commit 84d8e9e into gotosleep:master May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants