Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pasting citadels to structures module results in some results being deleted #20

Closed
samoneilll opened this issue Sep 17, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@samoneilll
Copy link

https://i.imgur.com/Um81v9c.gif

@samoneilll
Copy link
Author

Confirmed that this bug does not exist in Pathfinder v2.0

@barndawgie
Copy link

I am able to reproduce this as well. If I add 3 structures via D-Scan, 2 are immediately deleted. If I add again, 1 is deleted - so I can only add 1 structure at a time via the D-Scan paste option.

@samoneilll samoneilll changed the title Pasting citadels to structures module results in some results being deleted [BUG] Pasting citadels to structures module results in some results being deleted Oct 26, 2021
@TyrHeimdalEVE TyrHeimdalEVE added bug Something isn't working help wanted Extra attention is needed labels Nov 1, 2021
@samoneilll
Copy link
Author

Tracked down the issue. Structures were being saved correctly into the 'structure' table, however the associated 'corporation_structure' record that is used to build the systemData was being overwritten on each iteration when looping over structures in the pasted data, resulting in only the last structure on the list being properly persisted to the DB.

I have solved by simply resetting the CorporationStructureModel instance when saving corporation structures (f343753f). I'm not sure if this is a good fix or a hacky one, but I know very little PHP, so unless anybody has a better solution I will include in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants