refactor: simplify validateImager, validateManifester #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5366 +/- ##
==========================================
- Coverage 83.77% 82.67% -1.11%
==========================================
Files 135 150 +15
Lines 13029 14929 +1900
==========================================
+ Hits 10915 12342 +1427
- Misses 1677 2052 +375
- Partials 437 535 +98 ☔ View full report in Codecov by Sentry. |
caarlos0
reviewed
Dec 12, 2024
alexandear
force-pushed
the
refactor/docker-validate-manifester-imager
branch
from
43aa96f to
9298a2c
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR simplifies
validateManifesterandvalidateImagerfunctions. Also, adds tests to prove that refactoring doesn't break anything.