Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inclusive words and update pylint.config #548

Closed
dandhlee opened this issue Aug 30, 2021 · 3 comments · Fixed by #561
Closed

Use inclusive words and update pylint.config #548

dandhlee opened this issue Aug 30, 2021 · 3 comments · Fixed by #561
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API.

Comments

@dandhlee
Copy link
Contributor

There are mentions of non-inclusive words in pylint.config. Not sure how to update this file, please update it from master to main or other applicable inclusive terms. Please also update any other mentions of non-inclusive terms in the library proto or in this repository in general!

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 30, 2021
@larkee
Copy link
Contributor

larkee commented Aug 30, 2021

The non-inclusive words in pylint.config are a result of the imported pylint code. The change would first need to be made in that repo: https://github.com/GoogleCloudPlatform/python-repo-tools

@dandhlee
Copy link
Contributor Author

Thanks for pointing where it comes from! Never seen it for myself until now 😅

Origin: https://github.com/GoogleCloudPlatform/python-repo-tools/blob/master/gcp_devrel/tools/pylint.py

gcf-merge-on-green bot pushed a commit that referenced this issue Aug 31, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-spanner/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Unsure how to update https://github.com/googleapis/python-spanner/blob/master/pylint.config.py#L25-L28, filed #548 to keep track of it.

Fixes #547  🦕
tseaver added a commit that referenced this issue Aug 31, 2021
@tseaver
Copy link
Contributor

tseaver commented Aug 31, 2021

@larkee, @dandhlee We no longer actually use pylint at all (since googleapis/google-cloud-python#4921). Fossils removed in PR #561.

larkee pushed a commit that referenced this issue Aug 31, 2021
* chore: remove fossils of pylint

Closes #548.

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants