feat(spanner): add samples for instance partitions #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
api: spanner
samples/samples/snippets_test.py
Outdated
| @@ -188,6 +195,33 @@ def test_create_instance_with_autoscaling_config(capsys, lci_instance_id): | |||
| retry_429(instance.delete)() | |||
|
|
|||
|
|
|||
| def test_create_instance_partition(capsys, instance_partition_instance_id): | |||
| spanner_client = spanner.Client() | |||
| operation = spanner_client.instance_admin_api.create_instance( | |||
There was a problem hiding this comment.
Can we follow one of the 2 approaches,
- We can re-use existing instance that is already created in .
This will prevent instance creation time when running tests and also reduce the no of instances that get created.
This test can be marked as dependent to the instance creation test like
- If above one is complicated, then can we directly use snippets.create_instance to create an instance instead of rewriting the create logic here?
There was a problem hiding this comment.
I implemented Approach 2. The challenge with reusing an existing instance is that there are several restrictions around instance partitions. Notably:
- An instance partition cannot have the same instance config as the parent instance
- Several Spanner features do not work in instances where the user has created one or more instance partitions.
product-auto-label
bot
added
size: s
harshachinta
approved these changes
Jul 30, 2024
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕