Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update metadata tests to use google_auth_mock. #1486

Merged
merged 4 commits into from
Jul 12, 2022
Merged

chore: Update metadata tests to use google_auth_mock. #1486

merged 4 commits into from
Jul 12, 2022

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jul 11, 2022 •
edited
Loading

This change includes an update to make Metadata tests pass in our internal infra.
Also includes formatting update to nox file.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@SinaChavoshi SinaChavoshi requested review from sararob and jialuzh July 11, 2022 20:32
@SinaChavoshi SinaChavoshi requested review from a team as code owners July 11, 2022 20:32
@SinaChavoshi SinaChavoshi requested a review from leahecole July 11, 2022 20:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jul 11, 2022
@SinaChavoshi SinaChavoshi merged commit 0833b1e into googleapis:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayaknishant nayaknishant nayaknishant approved these changes

@sararob sararob sararob approved these changes

@jialuzh jialuzh Awaiting requested review from jialuzh

@leahecole leahecole Awaiting requested review from leahecole leahecole was automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SinaChavoshi @sararob @nayaknishant