feat: Add PrivateEndpoint class and HTTP methods #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sasha-gitg
requested changes
Jun 23, 2022
…into private-ep
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sasha-gitg
approved these changes
Jun 28, 2022
nayaknishant
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sararob
pushed a commit
to sararob/python-aiplatform
that referenced
this pull request
Jun 29, 2022
* Add `network` to SDK initializer * Add urllib3 to library requirements * Fix network init() docstrings * Update Model/Endpoint docs to use top namespace * Add core Private Endpoint wrapper * Drop logs, add URI props * Lint, update typing for Prediction class * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add bug refs, test stubs, minor fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * test commit * adding examples, slight changes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding deployed model check: q * adding deployed model check * minor changes, adding error catching for explanations * testing to get other fields * removing edge case * adding print statement for debugging explain * using GET instead of POST for explain * using GET instead of POST for explain * using GET instead of POST for explain * removing explain for now, adding model id * removing explain for now, adding model id * removing explain for now, adding model id * cleaned and added docstrings * adding explain back * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removing explain until working * cleaning up docstrings * create test done, working on predict * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added unit tests for PrivateEndpoint * test debugging * fixing unit tests * adding fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * formatting encryption_spec_key_name * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing comments * adjusting traffic for private endpoint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adjusting traffic for private endpoint * adjusting traffic for private endpoint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding fixes * added delete for private Endpoint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing traffic percentage * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * using network instead of class, moving exceptions * cleaning up docstrings * adding fixes, delete testing * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding fixes * adding Raises section to private Endpoint docstrings * added private Endpoint check in init, added to testing * added private Endpoint check in init, added to testing * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding try/except inside functions, fixing tests, misc fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * reverting _validate_deploy_args method * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixed type hint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * lint issue * lint issue * adding system tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding system test changes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding shared_state to system test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trying outside import * putting imports back inside * added system test changes * added system test changes * adding fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing system test and init fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding fixes * adding fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adding fixes * adding fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added global network arg to associated classes * style formatting * docstring fixes * adding extra info to network arg docstring * adding extra info to network arg docstring * removing changes to noxfile * reverting noxfile * reverting noxfile * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * reverting job files to not include global network * reverting initalizer to not include global network config * removing global network config * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added fix and test to models * added fix and test to models * simplifying delete method Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: nayaknishant <nishantnayak@google.com> Co-authored-by: sasha-gitg <44654632+sasha-gitg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PrivateEndpointclass which subclassesEndpointpredict,explainandhealth_checkmethods to make unauthenticated REST HTTP calls to model server within networknetworktoaiplatform.init()and associated classes, reading the field inModel.deploy&Endpoint.createurllib3dependency requirement to libraryPrivateEndpointFixes #708, b/194725522 , b/211371627 (partial), b/220936610, b/230003208, b/233758779 🦕