Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

test: make product search tests run #269

Merged
merged 44 commits into from
Nov 29, 2018
Merged

test: make product search tests run #269

merged 44 commits into from
Nov 29, 2018

Conversation

nirupa-kumar
Copy link
Contributor

@nirupa-kumar nirupa-kumar commented Nov 14, 2018 •
edited
Loading

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
Fixing failing Product Search tests

  • Importing a Product set is taking longer than necessary and as hence been marked as skip.
  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Rebecca Taylor and others added 2 commits November 13, 2018 14:51
mv samples/productSearch/system-test/* samples/system-test/
ab03d7c 
Running `npm test` wasn't running these samples

I wasn't sure of a better, more idiomatic way to hook up these tests
so that they run. They weren't running on CI either (and were failing!)
@nirupa-kumar
failing test fixes
58fb6e2
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018 •
edited
Loading

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #269   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7def116...87679cd. Read the comment docs.

@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 14, 2018
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
JustinBeckwith
JustinBeckwith suggested changes Nov 27, 2018
View reviewed changes
samples/system-test/faceDetection.test.js Outdated Show resolved Hide resolved
samples/system-test/faceDetection.test.js Show resolved Hide resolved
samples/system-test/productSearch.v1p3beta1.test.js Outdated Show resolved Hide resolved
samples/system-test/productSearch.v1p3beta1.test.js Outdated Show resolved Hide resolved
samples/system-test/productSets.v1p3beta1.test.js Outdated Show resolved Hide resolved
samples/system-test/productSearch.v1p3beta1.test.js Show resolved Hide resolved
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2018
@nirupa-kumar
Copy link
Contributor Author

Failing because of the Face detection test.

@nirupa-kumar nirupa-kumar mentioned this pull request Nov 28, 2018
Closed
@beccasaurus beccasaurus mentioned this pull request Nov 28, 2018
Closed
3 tasks
JustinBeckwith
JustinBeckwith suggested changes Nov 28, 2018
View reviewed changes
.kokoro/samples-test.sh Outdated Show resolved Hide resolved
@nirupa-kumar
Copy link
Contributor Author

@JustinBeckwith
All errors have been fixed. Please let me know if there is anything else.

@JustinBeckwith JustinBeckwith removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2018
@JustinBeckwith JustinBeckwith changed the title Make product search tests run test: make product search tests run Nov 29, 2018
@JustinBeckwith JustinBeckwith merged commit e224ace into googleapis:master Nov 29, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@beccasaurus beccasaurus beccasaurus left review comments

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nirupa-kumar @beccasaurus @JustinBeckwith @googlebot @kokoro-team