Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

build: configure Windows build on Kokoro #165

Merged
merged 5 commits into from
Aug 10, 2018
Merged

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Aug 9, 2018

Also require internal approvals.

@ghost ghost assigned jkwlui Aug 9, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2018
@jkwlui jkwlui requested a review from a team August 9, 2018 01:31
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #165   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f52b5...be8a7a3. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

I just noticed something - can you confirm that codecov is successfully reporting stats?

@jkwlui
Copy link
Member Author

jkwlui commented Aug 9, 2018

We also need to figure out how to upload codecov to codecov.io. The npm module that does it only works out of the box for CircleCI (and others).

@jkwlui
Copy link
Member Author

jkwlui commented Aug 9, 2018

...or do you mean codecov is not reporting the entire src/?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants