This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
samples: add presubmit lint check #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…samples * chore(java_templates): add lint/static analysis presubmit checks for samples * chore: fix trailing whitespace Source-Author: Jeff Ching <chingor@google.com> Source-Date: Mon Aug 17 14:29:16 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: c3caf0704f25a0c365f1c315e804a30b87c62a75 Source-Link: googleapis/synthtool@c3caf07
This was creating too much noise. We will revisit with other options and/or tune these checks. Source-Author: Jeff Ching <chingor@google.com> Source-Date: Wed Aug 19 12:26:49 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9602086c6c5b05db77950c7f7495a2a3868f3537 Source-Link: googleapis/synthtool@9602086
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
Coverage 76.54% 76.54%
Complexity 502 502
=========================================
Files 24 24
Lines 3944 3944
Branches 48 48
=========================================
Hits 3019 3019
Misses 841 841
Partials 84 84 Continue to review full report at Codecov.
|
chingor13
changed the title
chingor13
approved these changes
Aug 20, 2020
chingor13
added
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/a79f8a17-dbb5-42d4-99e9-73d2b5ffda4d/targets
Source-Link: googleapis/synthtool@9602086
Source-Link: googleapis/synthtool@c3caf07