This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
feat: Introduce automatic LRO polling, integrate latest compute API definitions #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: compute
|
@georgiyekkert PTAL. Please update Integration Test according to the changes. The expected changes:
|
eaball35
approved these changes
Dec 2, 2021
Neenu1995
added
automerge
Neenu1995
changed the title
…-compute into owlbot-migration
vam-google
changed the title
|
Hi @georgiyekkert, |
|
Looking |
vam-google
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
I was able to reproduce the issue locally, an image insert fails with: errors:
I'm going to try to fix or skip this test. The error doesn't look related to library changes. |
|
confirmed: it's not a library issue, the API has a limitation - you can create only 6 images per hour per project. I'll update test in a separate PR. |
Neenu1995
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.6.0](https://www.github.com/googleapis/java-compute/compare/v1.5.0...v1.6.0) (2021-12-07) ### Features * Introduce automatic LRO polling, integrate latest compute API definitions ([#583](https://www.github.com/googleapis/java-compute/issues/583)) ([90f7b41](https://www.github.com/googleapis/java-compute/commit/90f7b41dfc91a45981786a2eeed2f21bf82febeb)) * Introduce automatic LRO polling; all LRO methods now return `OperationFuture<>` instead of `Operation` and poling is done automatically; calling `cancel()` on the future will cancel polling but not the operation itself on the server side. ([90f7b41](https://www.github.com/googleapis/java-compute/commit/90f7b41dfc91a45981786a2eeed2f21bf82febeb)) ### Bug Fixes * **java:** java 17 dependency arguments ([#571](https://www.github.com/googleapis/java-compute/issues/571)) ([b280ec0](https://www.github.com/googleapis/java-compute/commit/b280ec0781b13ae479c21202bfbc4c7c90d5868f)) * rename `IPProtocol` to `IPProtocolEnum` ([90f7b41](https://www.github.com/googleapis/java-compute/commit/90f7b41dfc91a45981786a2eeed2f21bf82febeb)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([#579](https://www.github.com/googleapis/java-compute/issues/579)) ([54bbe3a](https://www.github.com/googleapis/java-compute/commit/54bbe3a5c5e3c2d86fa6cde9182fae2349641f2e)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.1 ([#586](https://www.github.com/googleapis/java-compute/issues/586)) ([100e21f](https://www.github.com/googleapis/java-compute/commit/100e21ffedc6b4a92b668985b09e1aa9afd5f3c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Introduce automatic LRO polling; all LRO methods now return
OperationFuture<>instead ofOperationand poling is done automatically; callingcancel()on the future will cancel polling but not the operation itself on the server side.chore: migrate to owlbot
fix: rename
IPProtocoltoIPProtocolEnum