Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run tests on ruby 2.6 #2851

Merged
merged 8 commits into from
Mar 20, 2019
Merged

run tests on ruby 2.6 #2851

merged 8 commits into from
Mar 20, 2019

Conversation

TheRoyalTnetennba
Copy link
Contributor

@TheRoyalTnetennba TheRoyalTnetennba commented Jan 28, 2019 •
edited
Loading

  • Set up kokoro's linux tests to include rubies 2.5.5 and 2.6.2
  • Set up OSx to test against 2.5.5 for PR's, and 2.3.8, 2.4.5, 2.5.5, and 2.6.2 for merges/nightlies
  • Centralize supported ruby versions and use that to generate build scripts and dockerfiles

#2825
GoogleCloudPlatform/ruby-docs-samples#390

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2019
@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2019
@TheRoyalTnetennba
Copy link
Contributor Author

Will hold off on merging until the major dependencies are ready for 2.6

@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
@TheRoyalTnetennba TheRoyalTnetennba added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 27, 2019
@blowmage
Copy link
Contributor

blowmage commented Mar 5, 2019

We should be able to support Ruby 2.6 now. Both the grpc and google-protobuf gems have releases that support 2.6. I have been able to run the full suite of tests on Ruby 2.6 locally.

blowmage
blowmage reviewed Mar 5, 2019
View reviewed changes
.kokoro/build.sh Outdated Show resolved Hide resolved
@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2019
blowmage
blowmage suggested changes Mar 6, 2019
View reviewed changes
Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@blowmage
Copy link
Contributor

blowmage commented Mar 7, 2019

Any thoughts on the BigQuery failure on Linux?

@blowmage blowmage mentioned this pull request Mar 7, 2019
Closed
@TheRoyalTnetennba
Copy link
Contributor Author

TheRoyalTnetennba commented Mar 7, 2019 •
edited
Loading

Any thoughts on the BigQuery failure on Linux?

They don't seem super consistent? I'm spreading out the nightly tests more - linux, osx, and windows are now each staggered by an hour. I don't know how much that will help.

@blowmage blowmage added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2019
@blowmage
Copy link
Contributor

blowmage commented Mar 8, 2019 •
edited
Loading

i am hesitant to approve this PR while the Linux build is red.

@blowmage blowmage added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 15, 2019
@TheRoyalTnetennba TheRoyalTnetennba removed the cla: no This human has *not* signed the Contributor License Agreement. label Mar 15, 2019
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 15, 2019
blowmage
blowmage reviewed Mar 15, 2019
View reviewed changes
.kokoro/osx.sh Outdated
@@ -28,6 +28,7 @@ function set_failed_status {
}

# Install/Use 2.5.5
source /Users/kbuilder/.rvm/scripts/rvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can also install and build against 2.3, 2.4, and 2.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll take forever, and my understanding is that the mac resources are much more limited than the GCP images. What if we tested all versions for nightly?

@blowmage
Copy link
Contributor

🎉 for passing linux build!

@blowmage
Copy link
Contributor

So close!

Required ruby-2.5.5 is not installed.
To install do: 'rvm install "ruby-2.5.5"'

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 19, 2019
@TheRoyalTnetennba TheRoyalTnetennba added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 19, 2019
@TheRoyalTnetennba
Copy link
Contributor Author

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@TheRoyalTnetennba TheRoyalTnetennba removed the needs work This is a pull request that needs a little love. label Mar 20, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 20, 2019
blowmage
blowmage approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@blowmage blowmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@quartzmo
Copy link
Member

From the passing Kokoro CI log:

ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-linux]
Fetching gem metadata from https://rubygems.org/........
Resolving dependencies....

Congratulations!!

@TheRoyalTnetennba TheRoyalTnetennba merged commit e528594 into master Mar 20, 2019
@TheRoyalTnetennba TheRoyalTnetennba deleted the new-ruby branch March 20, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowmage blowmage blowmage approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TheRoyalTnetennba @blowmage @googlebot @quartzmo @JustinBeckwith @yoshi-automation @yoshi-kokoro