chore: add a generation configuration #10357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
You should have run some command to generate this file. Would you write what command you ran in the pull request description? |
suztomo
approved these changes
Feb 20, 2024
suztomo
reviewed
Feb 20, 2024
|
|
||
| - api_shortname: accesscontextmanager | ||
| name_pretty: Identity Access Context Manager | ||
| product_documentation: n/a |
There was a problem hiding this comment.
This is because product_documentation is n/a.
We should verify the correctness of a field for new libraries.
suztomo
reviewed
Feb 20, 2024
| - license-checks.xml | ||
| - renovate.json | ||
| - .gitignore | ||
| libraries: |
There was a problem hiding this comment.
Would you explicitly define the order of the entries in libraries field? It will help where to add a new entry.
There was a problem hiding this comment.
Added as comment.
I created a script to generate the config file and I removed the script before sending the PR to review (3b763c3) |
|
Thank you |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
To generate libraries in the config file,
library_generationfolder from sdk-platform-java main branch to google-cloud-java root directory.Total generation time is 1 hour 4 mins on a gLinux Cloudtop.
Note that the path of the config file has to be absolute.
Four libraries (
java-alloydb-connects,java-bigquery-data-exchange,java-securitycenter,java-shopping-merchant-inventories) are commented out because they have the sameapi-shortnamewith other libraries and it will cause conflicts when generating libraries with the sameapi-shortname(googleapis/sdk-platform-java#2494). I will remove the comment once the problem is fixed.This is step 3 of milestone 2 in hermetic build project.