fix(spanner): remove session from pool upon "not found" refresh failure #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "SELECT 1" session-refresh query fails with "Session not found", remove the bad session from the pool, if possible. Previously we did nothing because (1) it shouldn't happen, and (2) we have other mechanisms in place to deal with bad sessions (which must remain). But it is better dealt with directly if we can. Fixes googleapis#4026.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.21% // Head: 94.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9954 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 1497 1497
Lines 140428 140489 +61
=======================================
+ Hits 132301 132362 +61
Misses 8127 8127
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
Sep 29, 2022
| }); | ||
| auto handler = | ||
| [pool, session_name = refresh.second]( | ||
| future<StatusOr<google::spanner::v1::ResultSet>> result) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "SELECT 1" session-refresh query fails with "Session not found", remove the bad session from the pool, if possible. Previously we did nothing because (1) it shouldn't happen, and (2) we have other mechanisms in place to deal with bad sessions (which must remain). But it is better dealt with directly if we can.
Fixes #4026.
This change is