Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): add lease management for unary pull #13428

Merged
merged 12 commits into from
Jan 25, 2024
Merged

feat(pubsub): add lease management for unary pull #13428

merged 12 commits into from
Jan 25, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Jan 10, 2024 •
edited
Loading

Closes #13298

This change is Reviewable

@alevenberg alevenberg added the do not review Indicates a PR is not ready for review label Jan 10, 2024
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 10, 2024
@alevenberg alevenberg marked this pull request as ready for review January 12, 2024 15:54
@alevenberg alevenberg requested a review from a team as a code owner January 12, 2024 15:54
@alevenberg alevenberg removed the do not review Indicates a PR is not ready for review label Jan 12, 2024
@alevenberg alevenberg enabled auto-merge (squash) January 12, 2024 17:29
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (db22daa) 93.08% compared to head (98e0cb8) 93.09%.
Report is 46 commits behind head on main.

Files Patch % Lines
...d/pubsub/internal/default_pull_ack_handler_test.cc 76.19% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13428   +/-   ##
=======================================
  Coverage   93.08%   93.09%           
=======================================
  Files        2172     2173    +1     
  Lines      189232   189278   +46     
=======================================
+ Hits       176151   176201   +50     
+ Misses      13081    13077    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg merged commit aa4b696 into googleapis:main Jan 25, 2024
60 checks passed
@alevenberg alevenberg deleted the hey-8 branch January 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pubsub] Add tracing for extend span for unary pull
3 participants
@alevenberg @coryan @dbolduc