Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support split packages #12049

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 7, 2023

With this change package maintainers can split google-cloud-cpp into smaller packages. Some package ecosystems have constraints on the build time for the packages, or on the size of the packages. google-cloud-cpp is exceeding some of these limits (notably build times on Conda). The solution is to create a smaller package with the core libraries, and then one or more packages with a subset of the features built on top of this core.

In addition to the necessary support in CMake, this introduces a build to test this configuration.

Motivated by conda-forge/google-cloud-cpp-feedstock#141


This change is Reviewable

With this change package maintainers can split `google-cloud-cpp` into
smaller packages. Some package ecosystems have constraints on the build
time for the packages, or on the size of the packages.
`google-cloud-cpp` is exceeding some of these limits (notably build
times on Conda). The solution is to create a smaller package with the
core libraries, and then one or more packages with a subset of the
features built on top of this core.

In addition to the necessary support in CMake, this introduces a build
to test this configuration.
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (21532e4) 93.68% compared to head (0ab92f6) 93.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12049   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files        2014     2014           
  Lines      175251   175251           
=======================================
+ Hits       164185   164192    +7     
+ Misses      11066    11059    -7     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review July 7, 2023 19:36
@coryan coryan requested a review from a team as a code owner July 7, 2023 19:36
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a full review)

CMakeLists.txt Outdated Show resolved Hide resolved
@coryan coryan merged commit 2c7bebb into googleapis:main Jul 10, 2023
@coryan coryan deleted the feat-install-features-after-common branch July 10, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants