fix(storage): cache legacy credentials #11271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we missed the caching feature during the multiple refactorings. The test is (maybe) not ideal, but the API is not easy to test, and we do not want to change it.
product-auto-label
bot
added
the
api: storage
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11271 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 1764 1764
Lines 159074 159096 +22
=======================================
+ Hits 149174 149200 +26
+ Misses 9900 9896 -4
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we missed the caching feature during the multiple refactorings. The test is (maybe) not ideal, but the API is not easy to test, and we do not want to change it.
Fixes #11194
This change is