Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datacatalog): generate lineage library #10977

Merged
merged 4 commits into from
Mar 1, 2023
Merged

feat(datacatalog): generate lineage library #10977

merged 4 commits into from
Mar 1, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 1, 2023 •
edited
Loading

Fixes #10682.

WARNING: note that the library is marked as experimental. #10976

This change is Reviewable

@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the Data Catalog API. label Mar 1, 2023
@coryan coryan marked this pull request as ready for review March 1, 2023 13:22
@coryan coryan requested a review from a team as a code owner March 1, 2023 13:22
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (b6bbb60) 93.64% compared to head (8a8f8dd) 93.64%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10977   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files        1721     1721           
  Lines      154959   154959           
=======================================
+ Hits       145115   145116    +1     
+ Misses       9844     9843    -1
Impacted Files Coverage Δ
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.34%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.33%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 100.00% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dbolduc
dbolduc approved these changes Mar 1, 2023
View reviewed changes
google/cloud/datacatalog/BUILD.bazel Show resolved Hide resolved
google/cloud/datacatalog/CMakeLists.txt Outdated Show resolved Hide resolved
@coryan coryan enabled auto-merge (squash) March 1, 2023 15:18
@coryan coryan merged commit 16ffa2e into googleapis:main Mar 1, 2023
@coryan coryan deleted the feat-datacatalog-generate-lineage-library branch March 1, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
api: datacatalog Issues related to the Data Catalog API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate library for datalineage.googleapis.com
2 participants
@coryan @dbolduc