Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pubsub): rename SchemaStub #10064

Merged
merged 1 commit into from
Oct 18, 2022
Merged

refactor(pubsub): rename SchemaStub #10064

merged 1 commit into from
Oct 18, 2022
+98 −85

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 18, 2022 •
edited
Loading

Use the name that the generator will use: SchemaServiceStub.

Part of the work for #7187

This change is Reviewable

@coryan
refactor(pubsub): rename SchemaStub
47467fc 
Use the name that the generator will use: `SchemaServiceStub`.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 18, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 47467fce28a2398088893d70161ab41534784f64

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 94.23% // Head: 94.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (47467fc) compared to base (8cf365b).
Patch coverage: 96.49% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10064   +/-   ##
=======================================
  Coverage   94.23%   94.24%           
=======================================
  Files        1537     1537           
  Lines      142068   142069    +1     
=======================================
+ Hits       133880   133886    +6     
+ Misses       8188     8183    -5
Impacted Files Coverage Δ
google/cloud/pubsub/schema_admin_connection.h 100.00% <ø> (ø)
...oogle/cloud/pubsub/schema_admin_connection_test.cc 100.00% <ø> (ø)
google/cloud/pubsub/testing/mock_schema_stub.h 100.00% <ø> (ø)
google/cloud/pubsub/schema_admin_connection.cc 90.38% <60.00%> (ø)
...gle/cloud/pubsub/internal/schema_auth_decorator.cc 100.00% <100.00%> (ø)
...ogle/cloud/pubsub/internal/schema_auth_decorator.h 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/schema_auth_test.cc 100.00% <100.00%> (ø)
.../cloud/pubsub/internal/schema_logging_decorator.cc 100.00% <100.00%> (ø)
...e/cloud/pubsub/internal/schema_logging_decorator.h 100.00% <100.00%> (ø)
...oogle/cloud/pubsub/internal/schema_logging_test.cc 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 18, 2022 19:16
@coryan coryan requested a review from a team as a code owner October 18, 2022 19:16
@coryan coryan enabled auto-merge (squash) October 18, 2022 19:16
@coryan coryan merged commit 9eee84e into googleapis:main Oct 18, 2022
@coryan coryan deleted the cleanup-pubsub-use-generator-for-stubs-pr4 branch October 18, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coryan @google-cloud-cpp-bot @dbolduc