Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document when GrpcNumChannelsOption applies #10000

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 7, 2022

Fixes #8906


This change is Reviewable

@dbolduc dbolduc requested a review from a team as a code owner October 7, 2022 18:33
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 244019ad16e578d8b6c04ad7a5b925f823cbb21d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 94.23% // Head: 94.22% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (244019a) compared to base (17d8909).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10000      +/-   ##
==========================================
- Coverage   94.23%   94.22%   -0.01%     
==========================================
  Files        1501     1501              
  Lines      141087   141087              
==========================================
- Hits       132949   132939      -10     
- Misses       8138     8148      +10     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...torage/examples/storage_service_account_samples.cc 96.47% <0.00%> (-1.18%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.84%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
google/cloud/storage/parallel_upload.cc 98.26% <0.00%> (-0.35%) ⬇️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc enabled auto-merge (squash) October 7, 2022 20:48
@dbolduc dbolduc disabled auto-merge October 7, 2022 21:59
@dbolduc dbolduc merged commit dd47583 into googleapis:main Oct 8, 2022
@dbolduc dbolduc deleted the doc-grpc-num-channels-option branch October 8, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document when GrpcNumChannelsOption applies
3 participants