Skip to content

Pubsub unary pull does not correctly trace mod acks #14020

Closed
@alevenberg

Description

@alevenberg

What's happening: TracingPullLeaseManager::StartLeaseLoop -> DefaultPullLeaseManager::StartLeaseLoop -> DefaultPullLeaseManager::ExtendLeaseLoop
What should happen: TracingPullLeaseManager::StartLeaseLoop -> DefaultPullLeaseManager::StartLeaseLoop -> TracingPullLeaseManager::ExtendLeaseLoop -> DefaultPullLeaseManager::ExtendLeaseLoop

I need to refactor this so it is like the streaming pull, the StartLeaseLoop will be a public interface and the ExtendLeaseLoop will be part of a nested class.

Example here: https://github.com/alevenberg/google-cloud-cpp/blob/8dcd1c028b7b6de5f6eb684a64bb17b0a915bcee/google/cloud/pubsub/quickstart/subscriber_pull_quickstart.cc

Activity

self-assigned this
on Apr 18, 2024
alevenberg

alevenberg commented on Apr 23, 2024

@alevenberg
MemberAuthor

The work is broken up into 4 parts:

  1. Initial refactoring to add the PullLeaseManagerImpl
  2. Refactor TracingPullLeaseManager unit tests for TracingPullLeaseManagerImpl
  3. Refactor DefaultPullLeaseManager unit tests for DefaultPullLeaseManagerImpl
  4. Refactor Factory unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Pubsub unary pull does not correctly trace mod acks · Issue #14020 · googleapis/google-cloud-cpp