fix: External credentials URL validations #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @lsirac |
amanda-tarafa
force-pushed
the
wif-url-validations
branch
from
7e5776a to
aa44cbc
Compare
jskeet
approved these changes
Oct 18, 2022
| [InlineData("https://iamcredentials-xyz.p1.googleapis.com")] | ||
| [InlineData("https://iamcredentials-xyz.p.foo.com")] | ||
| [InlineData("https://iamcredentials-xyz.p.foo.googleapis.com")] | ||
| public void ValidateImpersonationUrl_InvaliddUrl(string impersonationUrl) => |
There was a problem hiding this comment.
Nit - here and below - Invalidd => Invalid
| using System.Threading.Tasks; | ||
| using Xunit; | ||
|
|
||
| namespace Google.Apis.Auth.Tests.OAuth2 | ||
| { | ||
| public abstract class ExternalAccountCredentialTestsBase | ||
| public class ExternalAccountCredentialTestsBase |
There was a problem hiding this comment.
Hmm... does this mean that these tests end up being run multiple times, one for the base class and one for each derived class? Maybe these tests should be in a separate class instead?
There was a problem hiding this comment.
Oh yes you are right. Moving to a new class.
| private static readonly IEnumerable<Regex> ValidTokenUrlHostRegexes = new List<Regex> | ||
| { | ||
| // sts.xyz123.googleapis.com or exactly sts.googleapis.com | ||
| new Regex("^sts\\.([^\\.]+\\.)?googleapis\\.com$", RegexOptions.Compiled | RegexOptions.IgnoreCase), |
There was a problem hiding this comment.
I assume you're not using verbatim string literals so that we can just copy/paste from Java?
There was a problem hiding this comment.
Done, it was just left over from copy pasting.
amanda-tarafa
force-pushed
the
wif-url-validations
branch
from
aa44cbc to
a0b524c
Compare
amanda-tarafa
commented
Oct 18, 2022
| [InlineData("https://iamcredentials-xyz.p1.googleapis.com")] | ||
| [InlineData("https://iamcredentials-xyz.p.foo.com")] | ||
| [InlineData("https://iamcredentials-xyz.p.foo.googleapis.com")] | ||
| public void ValidateImpersonationUrl_InvaliddUrl(string impersonationUrl) => |
| using System.Threading.Tasks; | ||
| using Xunit; | ||
|
|
||
| namespace Google.Apis.Auth.Tests.OAuth2 | ||
| { | ||
| public abstract class ExternalAccountCredentialTestsBase | ||
| public class ExternalAccountCredentialTestsBase |
There was a problem hiding this comment.
Oh yes you are right. Moving to a new class.
| private static readonly IEnumerable<Regex> ValidTokenUrlHostRegexes = new List<Regex> | ||
| { | ||
| // sts.xyz123.googleapis.com or exactly sts.googleapis.com | ||
| new Regex("^sts\\.([^\\.]+\\.)?googleapis\\.com$", RegexOptions.Compiled | RegexOptions.IgnoreCase), |
There was a problem hiding this comment.
Done, it was just left over from copy pasting.
amanda-tarafa
force-pushed
the
wif-url-validations
branch
from
a0b524c to
c88e5c7
Compare
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Oct 18, 2022
Features - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
that referenced
this pull request
Oct 18, 2022
Features - #2228 Supports Quota Project environment variable for ADC. - #2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - #2216 Log errors when trying to reach Compute's metadata server. - #2177, #2197, #2200, #2206, #2215, #2235 Support for Workload Identity Federation and Worforce Identity Federation. - #2103 Compute credentials support explicit scopes. - #2096 Improves deserialization error handling.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Bug fixes: - googleapis#2273 Don't attempt to use an empty/null media type in batch responses - googleapis#2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - googleapis#2264 Which adds a missing line break in AWS Credential canonical request. Features - googleapis#2269 Support per-request max retry configuration. - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Dependencies: - Client libraries no longer target netstandard1.0 or net40. Bug fixes: - googleapis#2273 Don't attempt to use an empty/null media type in batch responses - googleapis#2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - googleapis#2264 Which adds a missing line break in AWS Credential canonical request. Features - googleapis#2269 Support per-request max retry configuration. - googleapis#2228 Supports Quota Project environment variable for ADC. - googleapis#2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - googleapis#2216 Log errors when trying to reach Compute's metadata server. - googleapis#2177, googleapis#2197, googleapis#2200, googleapis#2206, googleapis#2215, googleapis#2235 Support for Workload Identity Federation and Worforce Identity Federation. - googleapis#2103 Compute credentials support explicit scopes. - googleapis#2096 Improves deserialization error handling.
amanda-tarafa
added a commit
that referenced
this pull request
Nov 30, 2022
And support version: 1.58.0-beta02 => 1.58.0 Dependencies: - Client libraries no longer target netstandard1.0 or net40. Bug fixes: - #2273 Don't attempt to use an empty/null media type in batch responses - #2251 Which fixes a typo on then name of one of the AWS Credential environment variables. - #2264 Which adds a missing line break in AWS Credential canonical request. Features - #2269 Support per-request max retry configuration. - #2228 Supports Quota Project environment variable for ADC. - #2219 Removes obsolete OOB code. BREAKING CHANGE: We have removed OOB support from the library because the feature is not supported by Google OAuth as of October 3rd 2022. See the [official announcement](https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob) for more information. - #2216 Log errors when trying to reach Compute's metadata server. - #2177, #2197, #2200, #2206, #2215, #2235 Support for Workload Identity Federation and Worforce Identity Federation. - #2103 Compute credentials support explicit scopes. - #2096 Improves deserialization error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.