feat: expose underlying *spanner.Client #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the exposed features of go-sql-spanner are not sufficient to get the necessary response. This adds an escape hatch to access the underlying client. Fixes googleapis#312
olavloite
reviewed
Nov 12, 2024
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@olavloite I removed the restriction. I initially thought the batching was actively using the client somehow. I think I addressed all the pending questions. |
olavloite
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the exposed features of go-sql-spanner are not sufficient to get the necessary response. This adds an escape hatch to access the underlying client.
Fixes #312