regen protos with protoc 1.3.1 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Do we know if we're good to move forward with this PR? |
|
@tbpg Since we've just released, I'd say it's 👍 to go ahead with this and see what breaks. If something is hugely wrong with this we can roll back before v0.40.0. :) |
tbpg
approved these changes
May 13, 2019
This allows removal of x/net/sync and x/net/context, which is a welcome change. BREAKING_CHANGE_ACCEPTABLE=protoc churn
jeanbza
added a commit
to jeanbza/gax-go
that referenced
this pull request
May 13, 2019
Relevant context: googleapis/go-genproto#164 Also removes unnecessary (and troublesome) go1.12 line in v2/.
jeanbza
added a commit
to jeanbza/gax-go
that referenced
this pull request
May 13, 2019
Relevant context: googleapis/go-genproto#164 Also removes unnecessary (and troublesome) go1.12 line in v2/.
jeanbza
added a commit
to googleapis/gax-go
that referenced
this pull request
May 13, 2019
Relevant context: googleapis/go-genproto#164 Also removes unnecessary (and troublesome) go1.12 line in v2/.
|
You broke our build. Also there is no tag of the 1.2.* version so we cannot even pin to that. |
Please file a bug including the failure and all versions of relevant code you're using ( |
gopherbot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
May 20, 2019
Relevant context: googleapis/go-genproto#164 Change-Id: I238304d9150454b8e09dca9b02f844eb95f77754 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/41170 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not at all clear to me yet whether this change is safe or not.