Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

HttpJsonCallContext is final and @InternalExtensionOnly #1291

Closed
elharo opened this issue Feb 4, 2021 · 1 comment · Fixed by #1304
Closed

HttpJsonCallContext is final and @InternalExtensionOnly #1291

elharo opened this issue Feb 4, 2021 · 1 comment · Fixed by #1304
Assignees
@miraleung
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Feb 4, 2021

There's no reason a final class should be @InternalExtensionOnly since it can't be extended.
@elharo elharo added the type: cleanup An internal cleanup or hygiene concern. label Feb 4, 2021
@elharo
Copy link
Contributor Author

elharo commented Feb 5, 2021

same issue in GrpcCallContext

@miraleung miraleung self-assigned this Feb 18, 2021
@miraleung miraleung mentioned this issue Feb 18, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miraleung miraleung

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unused @InternalExtensionOnly from CallContext classes [gax-java] googleapis/gax-java
2 participants
@elharo @miraleung