Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/gax-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.12.1
Choose a base ref
...
head repository: googleapis/gax-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.12.2
Choose a head ref
  • 3 commits
  • 12 files changed
  • 2 contributors

Commits on Feb 9, 2022

  1. fix: REST: Make make LRO stub accept APIs of different versions (#1622)

    Prior to this fix it worked only with `v1` APIs. `HttpJsonOperationsStub` is shared by multiple different services similarly to `GrpcOperationsStub`. Unlike grpc version, the verison of the actual API that this stub is used by is supposed to be encoded in the http url, so the `HttpJsonOperationsStub` must adjust to the actual version of the API it is being used from. Similarly we also need to make the url patterns less restrictive, to accept operaion names in different formats (this is what caused the `{name=}` pattern changes).
    
    The solution is hacky, but simple and should work for all known APIs. It is based on the fact that even though the `HttpJsonOperationsStub` is shared by all clients (i.e. is in `gax`), its `HttpJsonStubCallbackFactory` argument, on the other hand, is a generated one (i.e. is in a gapic client for a specific API) and its package corresponds to the API version, which is a convention for all google APIs (i.e. version in the proto package corresponds to the version of the API).
    
    Doing this the other way would require a lot of work (parsing yaml, generating operations stub on the fly etc), and we may come back to it if even needed (most probably never).
    vam-google authored Feb 9, 2022
    Configuration menu
    Copy the full SHA
    3ae8d85 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 2.12.2-SNAPSHOT (#1623)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ### Updating meta-information for bleeding-edge SNAPSHOT release.
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    release-please[bot] authored Feb 9, 2022
    Configuration menu
    Copy the full SHA
    5e55b3b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. chore(main): release 2.12.2 (#1624)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a4ae0bb View commit details
    Browse the repository at this point in the history
Loading