Fixed token refresh process to use proxy #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
I used a proxy to authenticate with the Google Ad Manager API.
ad_manager_api.yml
I was able to communicate with the API through the proxy, but after an hour or so, the API stopped responding to me.
Due to the fact that the expiration time was one hour (
:expires_in: 3599
) , I assumed that the refresh process had failed.I checked the code. I noticed that
fetch_access_token!
uses a proxy, butrefresh!
does not.google-api-ads-ruby/ads_common/lib/ads_common/auth/oauth2_handler.rb
Line 227 in bac3587
google-api-ads-ruby/ads_common/lib/ads_common/auth/oauth2_handler.rb
Line 103 in bac3587
I made a patch to use proxy in
refresh!
as well, and now I can communicate with the API.If there is another way to solve this problem, I would appreciate it if you could let me know. Thank you.