[Swift] Fix latent inout argument differentiation bugs.
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mutating` functions like `Array.append` and `ActionValueCalculator.loss` cannot be differentiated because differentiation does not yet support function applications with `inout` arguments. These latent bugs were uncovered in swiftlang/swift#28352, which correctly diagnoses function applications with `inout` arguments. https://bugs.swift.org/browse/TF-129 tracks `inout` argument support. In the meantime, disable affected code and tests.
|
Why does AD diagnose on these? It looks to me like the inout arguments aren't active so differentiation should work even without inout argument support. |
OpenSpiel
pushed a commit
that referenced
this pull request
Nov 20, 2019
PiperOrigin-RevId: 281540491 Change-Id: Ib3bf1ae3fece0f664dc13da23df69a077c883665
Thanks for the catch! It's likely this patch wasn't correct, I'll investigate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutatingfunctions likeArray.appendandActionValueCalculator.losscannot be differentiated because differentiation does not yet support
function applications with
inoutarguments.These latent bugs were uncovered in swiftlang/swift#28352,
which correctly diagnoses function applications with
inoutarguments.https://bugs.swift.org/browse/TF-129 tracks
inoutargument support.In the meantime, disable affected code and tests.
Manually tested with Swift for TensorFlow nightly development toolchains.
Unblocks Swift for TensorFlow CI.