removing "fixed grid" #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think at this point coin_game, laser_tag, and markov_soccer all have grid/grid-size game parameters so we can remove this part.
|
Thanks. I copied the change and it will be in, in the next release. Closing now as the tool will not close this one automatically (as I copy-pasted it and did not applied the PR directly). |
|
Hey @jblespiau: re-opening until we update (btw it does autoclose-- tgst is what I have been doing... I think it uses the commit number(s)). I plan to do an update tonight or tomorrow. |
|
Nevermind, I am wrong because JB didn't import it the same way we import the rest. So I'm closing this one manually. |
OpenSpiel
pushed a commit
that referenced
this pull request
Nov 12, 2019
PiperOrigin-RevId: 279960897 Change-Id: Idec5b260b91dd1f63ba2d18857f4caf2db83255e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think at this point coin_game, laser_tag, and markov_soccer all have grid/grid-size game parameters so we can remove this part.