Fix python liar's poker available actions and update default game values #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w07wong
changed the title
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an off by one error for the bidding actions available in Liar's poker.
If the _current_action was a bid action, the action right after that bid (current bid + 1) would be skipped due to the loop beginning at current bid + 1 and then an additional BID_ACTION_OFFSET (value is 1) being added. This would result in the next bid action available to be current bid + 2 instead of current bid + 1.
Also increased the default hand length and allowed all digits to be used in the game.
Updated playthrough.