Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dark Hex observation tensor and infostate tensor bugs #1047

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

VitamintK
Copy link
Contributor

For dark hex, observation tensors with "reveal-numturns" were erroring on games of max length. Fixed by adding 1 to the observation tensor length.

Also, infostate tensors with "reveal-numturns" were erroring on games of max length. Fixed by using the num_cells_th bit instead of num_cells_+1th bit for unknown action.

Ran the following script to generate a playthrough as a regression test. Verified that it errored on master.

python open_spiel/python/examples/playthrough.py \
--game "dark_hex(gameversion=adh,obstype=reveal-numturns)" \
--output_file open_spiel/integration_tests/playthroughs/dark_hex_reveal_turn_long.txt \
--alsologtostdout --actions "0,2,1,3,4,6,5,7,7,5,6,4,3,1,2,0,8"

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Mar 30, 2023
@lanctot lanctot merged commit 2229aa0 into google-deepmind:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants