add simultaneous node support in policy_aggregator.py and exploitability.py #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemarris
suggested changes
Mar 17, 2023
| @@ -228,13 +246,10 @@ def assert_type(cond, msg): | |||
| if pid == turn_player: | |||
| # update the current node | |||
| # will need the observation to query the policies | |||
| if state not in self._policy: | |||
| if state_key not in self._policy: | |||
There was a problem hiding this comment.
Is this fixing a bug that existed in the code previously?
There was a problem hiding this comment.
Yes I believe this should be state_key instead of state. Because state is a pyspiel.state object which doesn't seem right to be a key.
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found several algorithms like the ones in policy_aggregator.py and exploitability.py didn't handle cases for simultaneous nodes. So this PR is to address this issue.