fix bug in acpc aka universal poker's MaxGameLength calculation #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h was causing very big infostate tensor sizes)
|
Hi @VitamintK, thanks! The tests are failing, can you regenerate the playthroughs? |
|
done |
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Universal Poker (ACPC).
This was noticeably causing infostate tensors to be very large. With default parameters*, the MaxGameLength was coming out as
2178, and so infostate tensors were size4406.After this fix, MaxGameLength is
16and infostate tensor size is82.* default parameters:
{'betting': 'nolimit', 'bettingAbstraction': 'fcpa', 'blind': '100 100', 'boardCards': '', 'firstPlayer': '1 1', 'handReaches': '', 'maxRaises': '', 'numBoardCards': '0 1', 'numHoleCards': 1, 'numPlayers': 2, 'numRanks': 6, 'numRounds': 2, 'numSuits': 4, 'potSize': 0, 'stack': '1200 1200'}