Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics settings db migration #8123

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Jan 23, 2024

🚨 Before you merge

Please ensure you've read the requirements for this issue and implications to consider before merging here.

Summary

Addresses issue:

Relevant technical choices

  • Renamed class to 1_119_0 since it might go out with current release, rather than next one

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

includes/Plugin.php Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 23, 2024

Build files for 12a0638 have been deleted.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the hard work here, @zutigrm.

I have left a few comments. Let's update the test cases and QAB accordingly as well.

Also, let's fix the merge conflicts.

Thanks!

includes/Core/Util/Migration_1_119_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_119_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_119_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_119_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_119_0.php Outdated Show resolved Hide resolved
@zutigrm
Copy link
Collaborator Author

zutigrm commented Jan 29, 2024

Thanks for the feedback @nfmohit . PR and QAB updated

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my feedback, @zutigrm. I have left a few comments, mostly suggestions. Please let me know what you think, thanks!

includes/Core/Util/Migration_1_121_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_121_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_121_0.php Outdated Show resolved Hide resolved
includes/Core/Util/Migration_1_121_0.php Outdated Show resolved Hide resolved
includes/Plugin.php Outdated Show resolved Hide resolved
@zutigrm
Copy link
Collaborator Author

zutigrm commented Jan 30, 2024

@nfmohit Thanks, PR updated

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aleksej! This looks perfect now.

I have pointed out a few very very minor changes in the test suite. I would've just gone ahead and applied them myself as they're so minor, but I'm not sure about one usage that I've pointed out here.

Apologies for the back and forth and thank you for your patience!

@zutigrm
Copy link
Collaborator Author

zutigrm commented Jan 31, 2024

@nfmohit Thank you, I forgot for a moment I still had these included. PR updated

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work, thank you @zutigrm.

Some very minor changes needed, so minor that I've applied them myself. I hope that's okay with you.

Thanks!

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @zutigrm !

@nfmohit nfmohit changed the base branch from develop to feature/singular-analytics-module March 6, 2024 09:05
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @nfmohit 🎖️

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,212 @@
<?php
/**
* Migration for 1.123.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably this should use the n.e.x.t placeholder, but seeing as the class name uses the underscore-separated format with the version hardwired, I think we can keep it as-is.

@techanvil techanvil merged commit a04a247 into feature/singular-analytics-module Mar 12, 2024
17 checks passed
@techanvil techanvil deleted the enhancement/8082-analytics-db-migration branch March 12, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants