Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max-width in footer notice to minimise shifting. #5595

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Remove max-width in footer notice to minimise shifting. #5595

merged 1 commit into from
Jul 21, 2022

Conversation

maciejost
Copy link
Collaborator

@maciejost maciejost commented Jul 21, 2022 •
edited
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

Size Change: -2 B (0%)

Total Size: 2.25 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 47.3 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 5.88 kB
./dist/assets/js/31-********************.js 2.8 kB
./dist/assets/js/32-********************.js 2.28 kB
./dist/assets/js/33-********************.js 3.72 kB
./dist/assets/js/34-********************.js 51.9 kB
./dist/assets/js/35-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 27.5 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 37.4 kB
./dist/assets/js/googlesitekit-api-********************.js 9.19 kB
./dist/assets/js/googlesitekit-base-********************.js 1.13 kB
./dist/assets/js/googlesitekit-dashboard-********************.js 62.5 kB
./dist/assets/js/googlesitekit-dashboard-details-********************.js 55.7 kB
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 70.7 kB
./dist/assets/js/googlesitekit-data-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.82 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 14.7 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 8.92 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 30 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 45.1 kB
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 25.6 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 69.1 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 19.1 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 69.1 kB
./dist/assets/js/googlesitekit-modules-********************.js 19.4 kB
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 27.9 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 19.4 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 18.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 39.3 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.5 kB
./dist/assets/js/googlesitekit-modules-thank-with-google-********************.js 899 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 380 B
./dist/assets/js/googlesitekit-settings-********************.js 50.8 kB
./dist/assets/js/googlesitekit-user-input-********************.js 44.7 kB
./dist/assets/js/googlesitekit-vendor-********************.js 323 kB
./dist/assets/js/googlesitekit-widgets-********************.js 19.2 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.8 kB
./dist/assets/js/runtime-********************.js 1.28 kB

compressed-size-action

tofumatt
tofumatt approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on mobile, tablet, and desktop! 👍🏻

@tofumatt tofumatt merged commit 4ebc699 into develop Jul 21, 2022
@tofumatt tofumatt deleted the enhancement/#5489-sharing-notice-css branch July 21, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejost @tofumatt